Change CI to GitHub actions

Use copier template from oca/oca-addons-repo-template

Target Python3.8

Apply linting

Fix a missing call to super
Ensure all modules have a 13.0.x.x.x version

attachment_swift/models/ir_attachment.py

@@ -5,9 +5,10 @@
 import base64
 import logging
 import os
-from ..swift_uri import SwiftUri
 
-from odoo import api, exceptions, models, _
+from odoo import _, api, exceptions, models
+
+from ..swift_uri import SwiftUri
 
 _logger = logging.getLogger(__name__)
 
@@ -49,8 +50,9 @@ class SwiftSessionStore(object):
     def _get_key(self, auth_url, username, password, project_name):
         return (auth_url, username, password, project_name)
 
-    def get_session(self, auth_url=None, username=None, password=None,
-                    project_name=None):
+    def get_session(
+        self, auth_url=None, username=None, password=None, project_name=None
+    ):
         key = self._get_key(auth_url, username, password, project_name)
         session = self._sessions.get(key)
         if not session:
@@ -59,13 +61,10 @@ class SwiftSessionStore(object):
                 password=password,
                 project_name=project_name,
                 auth_url=auth_url,
-                project_domain_id='default',
-                user_domain_id='default',
-            )
-            session = keystoneauth1.session.Session(
-                auth=auth,
-                timeout=SWIFT_TIMEOUT,
+                project_domain_id="default",
+                user_domain_id="default",
             )
+            session = keystoneauth1.session.Session(auth=auth, timeout=SWIFT_TIMEOUT,)
             self._sessions[key] = session
         return session
 
@@ -74,36 +73,38 @@ swift_session_store = SwiftSessionStore()
 
 
 class IrAttachment(models.Model):
-    _inherit = 'ir.attachment'
+    _inherit = "ir.attachment"
 
     def _get_stores(self):
-        l = ['swift']
-        l += super()._get_stores()
-        return l
+        stores = ["swift"]
+        stores += super()._get_stores()
+        return stores
 
     @api.model
     def _get_swift_connection(self):
         """ Returns a connection object for the Swift object store """
-        host = os.environ.get('SWIFT_AUTH_URL')
-        account = os.environ.get('SWIFT_ACCOUNT')
-        password = os.environ.get('SWIFT_PASSWORD')
-        project_name = os.environ.get('SWIFT_PROJECT_NAME')
-        if not project_name and os.environ.get('SWIFT_TENANT_NAME'):
-            project_name = os.environ['SWIFT_TENANT_NAME']
+        host = os.environ.get("SWIFT_AUTH_URL")
+        account = os.environ.get("SWIFT_ACCOUNT")
+        password = os.environ.get("SWIFT_PASSWORD")
+        project_name = os.environ.get("SWIFT_PROJECT_NAME")
+        if not project_name and os.environ.get("SWIFT_TENANT_NAME"):
+            project_name = os.environ["SWIFT_TENANT_NAME"]
             _logger.warning(
                 "SWIFT_TENANT_NAME is deprecated and "
                 "must be replaced by SWIFT_PROJECT_NAME"
             )
-        region = os.environ.get('SWIFT_REGION_NAME')
+        region = os.environ.get("SWIFT_REGION_NAME")
         os_options = {}
         if region:
-            os_options['region_name'] = region
+            os_options["region_name"] = region
         if not (host and account and password and project_name):
-            raise exceptions.UserError(_(
-                "Problem connecting to Swift store, are the env variables "
-                "(SWIFT_AUTH_URL, SWIFT_ACCOUNT, SWIFT_PASSWORD, "
-                "SWIFT_TENANT_NAME) properly set?"
-            ))
+            raise exceptions.UserError(
+                _(
+                    "Problem connecting to Swift store, are the env variables "
+                    "(SWIFT_AUTH_URL, SWIFT_ACCOUNT, SWIFT_PASSWORD, "
+                    "SWIFT_TENANT_NAME) properly set?"
+                )
+            )
         try:
             session = swift_session_store.get_session(
                 username=account,
@@ -112,17 +113,16 @@ class IrAttachment(models.Model):
                 auth_url=host,
             )
             conn = swiftclient.client.Connection(
-                session=session,
-                os_options=os_options,
+                session=session, os_options=os_options,
             )
         except ClientException:
-            _logger.exception('Error connecting to Swift object store')
-            raise exceptions.UserError(_('Error on Swift connection'))
+            _logger.exception("Error connecting to Swift object store")
+            raise exceptions.UserError(_("Error on Swift connection"))
         return conn
 
     @api.model
     def _store_file_read(self, fname, bin_size=False):
-        if fname.startswith('swift://'):
+        if fname.startswith("swift://"):
             swifturi = SwiftUri(fname)
             try:
                 conn = self._get_swift_connection()
@@ -130,32 +130,32 @@ class IrAttachment(models.Model):
                 _logger.exception(
                     "error reading attachment '%s' from object storage", fname
                 )
-                return ''
+                return ""
             try:
-                resp, obj_content = conn.get_object(swifturi.container(),
-                                                    swifturi.item())
+                resp, obj_content = conn.get_object(
+                    swifturi.container(), swifturi.item()
+                )
                 read = base64.b64encode(obj_content)
             except ClientException:
-                read = ''
-                _logger.exception(
-                    'Error reading object from Swift object store')
+                read = ""
+                _logger.exception("Error reading object from Swift object store")
             return read
         else:
             return super()._store_file_read(fname, bin_size)
 
     def _store_file_write(self, key, bin_data):
-        if self._storage() == 'swift':
-            container = os.environ.get('SWIFT_WRITE_CONTAINER')
+        if self._storage() == "swift":
+            container = os.environ.get("SWIFT_WRITE_CONTAINER")
             # replace {db} with the database name to handle multi-tenancy
             container = container.format(db=self.env.cr.dbname)
             conn = self._get_swift_connection()
             conn.put_container(container)
-            filename = 'swift://{}/{}'.format(container, key)
+            filename = "swift://{}/{}".format(container, key)
             try:
                 conn.put_object(container, key, bin_data)
             except ClientException:
-                _logger.exception('Error writing to Swift object store')
-                raise exceptions.UserError(_('Error writing to Swift'))
+                _logger.exception("Error writing to Swift object store")
+                raise exceptions.UserError(_("Error writing to Swift"))
         else:
             _super = super()
             filename = _super._store_file_write(key, bin_data)
@@ -163,18 +163,17 @@ class IrAttachment(models.Model):
 
     @api.model
     def _store_file_delete(self, fname):
-        if fname.startswith('swift://'):
+        if fname.startswith("swift://"):
             swifturi = SwiftUri(fname)
             container = swifturi.container()
             # delete the file only if it is on the current configured bucket
             # otherwise, we might delete files used on a different environment
-            if container == os.environ.get('SWIFT_WRITE_CONTAINER'):
+            if container == os.environ.get("SWIFT_WRITE_CONTAINER"):
                 conn = self._get_swift_connection()
                 try:
                     conn.delete_object(container, swifturi.item())
                 except ClientException:
-                    _logger.exception(
-                        _('Error deleting an object on the Swift store'))
+                    _logger.exception(_("Error deleting an object on the Swift store"))
                     # we ignore the error, file will stay on the object
                     # storage but won't disrupt the process
         else: