attachment_s3: Fix TypeError after setting bucket_name in s3 resource params

This commit is contained in:
Akim Juillerat
2021-10-05 16:55:14 +02:00
parent 6564ab7c97
commit 80fd0bf130
+3 -2
View File
@@ -45,7 +45,6 @@ class IrAttachment(models.Model):
bucket_name = bucket_name or os.environ.get('AWS_BUCKETNAME') bucket_name = bucket_name or os.environ.get('AWS_BUCKETNAME')
# replaces {db} by the database name to handle multi-tenancy # replaces {db} by the database name to handle multi-tenancy
bucket_name = bucket_name.format(db=self.env.cr.dbname) bucket_name = bucket_name.format(db=self.env.cr.dbname)
params = { params = {
'aws_access_key_id': access_key, 'aws_access_key_id': access_key,
'aws_secret_access_key': secret_key, 'aws_secret_access_key': secret_key,
@@ -74,7 +73,9 @@ class IrAttachment(models.Model):
""" """
params = self._get_s3_connection_params(bucket_name=name) params = self._get_s3_connection_params(bucket_name=name)
bucket_name = params.get('bucket_name') # Pop the bucket_name to avoid TypeError: resource() got an unexpected
# keyword argument 'bucket_name'
bucket_name = params.pop("bucket_name")
if not ( if not (
params["aws_access_key_id"] and params["aws_access_key_id"] and
params["aws_secret_access_key"] and params["aws_secret_access_key"] and