Change CI to GitHub actions

Use copier template from oca/oca-addons-repo-template

Target Python3.8

Apply linting

Fix a missing call to super

attachment_azure/__manifest__.py

@@ -9,13 +9,11 @@
     "Open Source Integrators, "
     "Serpent Consulting Services, "
     "Odoo Community Association (OCA)",
+    "website": "https://github.com/camptocamp/odoo-cloud-platform",
     "license": "AGPL-3",
     "category": "Knowledge Management",
     "depends": ["base_attachment_object_storage"],
-    "external_dependencies": {
-        "python": ["azure-storage-blob", "azure-identity"],
-    },
-    "website": "https://github.com/camptocamp/odoo-cloud-platform",
+    "external_dependencies": {"python": ["azure-storage-blob", "azure-identity"]},
     "installable": True,
     "development_status": "Beta",
     "post_init_hook": "_post_init_hook",

attachment_azure/controllers/main.py

@@ -1,11 +1,11 @@
 import logging
 import os
 
-from odoo.addons.web.controllers.main import Database
-from odoo import http
-from odoo import exceptions
+from odoo import exceptions, http
 from odoo.http import request
 
+from odoo.addons.web.controllers.main import Database
+
 _logger = logging.getLogger(__name__)
 
 

attachment_azure/models/ir_attachment.py

@@ -12,13 +12,13 @@ from odoo import _, api, exceptions, models
 _logger = logging.getLogger(__name__)
 
 try:
+    from azure.core.exceptions import HttpResponseError, ResourceExistsError
     from azure.storage.blob import (
-        BlobServiceClient,
-        generate_account_sas,
-        ResourceTypes,
         AccountSasPermissions,
+        BlobServiceClient,
+        ResourceTypes,
+        generate_account_sas,
     )
-    from azure.core.exceptions import ResourceExistsError, HttpResponseError
 except ImportError:
     _logger.debug("Cannot 'import azure-storage-blob'.")
 
@@ -32,9 +32,9 @@ class IrAttachment(models.Model):
     _inherit = "ir.attachment"
 
     def _get_stores(self):
-        l = ["azure"]
-        l += super(IrAttachment, self)._get_stores()
-        return l
+        stores = ["azure"]
+        stores += super()._get_stores()
+        return stores
 
     @api.model
     def _get_blob_service_client(self):
@@ -112,10 +112,8 @@ class IrAttachment(models.Model):
 
     @api.model
     def _get_container_name(self, db_name=None):
-        """
-        Container naming rules:
-        https://docs.microsoft.com/en-us/rest/api/storageservices/naming-and-referencing-containers--blobs--and-metadata#container-names
-        """
+        # Container naming rules:
+        # https://docs.microsoft.com/en-us/rest/api/storageservices/naming-and-referencing-containers--blobs--and-metadata#container-names  # noqa: B950
         running_env = os.environ.get("RUNNING_ENV", "dev")
         storage_name = os.environ.get("AZURE_STORAGE_NAME", r"{env}-{db}")
         storage_name = storage_name.format(
@@ -135,7 +133,7 @@ class IrAttachment(models.Model):
         except exceptions.UserError:
             _logger.exception(
                 "error accessing to storage '%s' please check credentials ",
-                container_name
+                container_name,
             )
             return False
         container_client = blob_service_client.get_container_client(container_name)
@@ -152,14 +150,14 @@ class IrAttachment(models.Model):
     def _store_file_read(self, fname, bin_size=False):
         if fname.startswith("azure://"):
             key = fname.replace("azure://", "", 1).lower()
-            if '/' in key:
-                container_name, key = key.split('/', 1)
+            if "/" in key:
+                container_name, key = key.split("/", 1)
             else:
                 container_name = None
             container_client = self._get_azure_container(container_name)
             # if container cannot be retrived, abort reading from azure storage
             if not container_client:
-                return ''
+                return ""
             try:
                 blob_client = container_client.get_blob_client(key)
                 read = blob_client.download_blob().readall()
@@ -199,13 +197,13 @@ class IrAttachment(models.Model):
     def _store_file_delete(self, fname):
         if fname.startswith("azure://"):
             key = fname.replace("azure://", "", 1).lower()
-            if '/' in key:
-                container_name, key = key.split('/', 1)
+            if "/" in key:
+                container_name, key = key.split("/", 1)
             else:
                 container_name = None
             container_client = self._get_azure_container(container_name)
             if not container_client:
-                return ''
+                return ""
             # delete the file only if it is on the current configured container
             # otherwise, we might delete files used on a different environment
             try: