From c3d9aceb0fa31e805bb4aa4992be14ec33a142cd Mon Sep 17 00:00:00 2001 From: Guewen Baconnier Date: Wed, 13 Jun 2018 17:16:07 +0200 Subject: [PATCH] Document a weird domain which is there for a reason The reason being: https://github.com/odoo/odoo/blob/9032617120138848c63b3cfa5d1913c5e5ad76db/odoo/addons/base/ir/ir_attachment.py#L344-L347 I nearly deleted this domain but it was too weird to be there for no reason. A comment explaining the issue was really missing. --- attachment_s3/models/ir_attachment.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/attachment_s3/models/ir_attachment.py b/attachment_s3/models/ir_attachment.py index 272e78f..2fe55a4 100644 --- a/attachment_s3/models/ir_attachment.py +++ b/attachment_s3/models/ir_attachment.py @@ -332,6 +332,11 @@ class IrAttachment(models.Model): if storage != 's3': return _logger.info('migrating files to the object storage') + # The weird "res_field = False OR res_field != False" domain + # is required! It's because of an override of _search in ir.attachment + # which adds ('res_field', '=', False) when the domain does not + # contain 'res_field'. + # https://github.com/odoo/odoo/blob/9032617120138848c63b3cfa5d1913c5e5ad76db/odoo/addons/base/ir/ir_attachment.py#L344-L347 domain = ['!', ('store_fname', '=like', 's3://%'), '|', ('res_field', '=', False),