Change CI to GitHub actions

Use copier template from oca/oca-addons-repo-template

Apply linting

base_attachment_object_storage/__manifest__.py

@@ -10,7 +10,7 @@
     "license": "AGPL-3",
     "category": "Knowledge Management",
     "depends": ["base"],
-    "website": "http://www.camptocamp.com",
+    "website": "https://github.com/camptocamp/odoo-cloud-platform",
     "data": ["data/res_config_settings_data.xml"],
     "installable": True,
     "auto_install": True,

base_attachment_object_storage/data/res_config_settings_data.xml

@@ -1,9 +1,11 @@
-<?xml version='1.0' encoding='utf-8'?>
+<?xml version='1.0' encoding='utf-8' ?>
 <odoo noupdate="1">
 
     <record id="ir_attachment_storage_force_database" model="ir.config_parameter">
         <field name="key">ir_attachment.storage.force.database</field>
-        <field name="value">{"image/": 51200, "application/javascript": 0, "text/css": 0}</field>
+        <field
+            name="value"
+        >{"image/": 51200, "application/javascript": 0, "text/css": 0}</field>
     </record>
 
 </odoo>

base_attachment_object_storage/models/ir_attachment.py

@@ -5,16 +5,16 @@ import inspect
 import logging
 import os
 import time
-from .strtobool import strtobool
+from contextlib import closing, contextmanager
 
 import psycopg2
-import odoo
 
-from contextlib import closing, contextmanager
-from odoo import api, exceptions, models, _
+import odoo
+from odoo import _, api, exceptions, models
 from odoo.osv.expression import AND, OR, normalize_domain
 from odoo.tools.safe_eval import const_eval
 
+from .strtobool import strtobool
 
 _logger = logging.getLogger(__name__)
 
@@ -242,7 +242,7 @@ class IrAttachment(models.Model):
             if not count:
                 self._store_file_delete(fname)
         else:
-            super()._file_delete(fname)
+            return super()._file_delete(fname)
 
     @api.model
     def _is_file_from_a_store(self, fname):
@@ -395,7 +395,8 @@ class IrAttachment(models.Model):
         # is required! It's because of an override of _search in ir.attachment
         # which adds ('res_field', '=', False) when the domain does not
         # contain 'res_field'.
-        # https://github.com/odoo/odoo/blob/9032617120138848c63b3cfa5d1913c5e5ad76db/odoo/addons/base/ir/ir_attachment.py#L344-L347
+        # https://github.com/odoo/odoo/blob/9032617120138848c63b3cfa5d1913c5e5ad76db/odoo/addons/base/ir/ir_attachment.py#L344-L347  # noqa: B950
+
         domain = [
             "!",
             ("store_fname", "=like", "{}://%".format(storage)),

base_attachment_object_storage/models/strtobool.py

@@ -1,21 +1,21 @@
 _MAP = {
-    'y': True,
-    'yes': True,
-    't': True,
-    'true': True,
-    'on': True,
-    '1': True,
-    'n': False,
-    'no': False,
-    'f': False,
-    'false': False,
-    'off': False,
-    '0': False
+    "y": True,
+    "yes": True,
+    "t": True,
+    "true": True,
+    "on": True,
+    "1": True,
+    "n": False,
+    "no": False,
+    "f": False,
+    "false": False,
+    "off": False,
+    "0": False,
 }
 
 
 def strtobool(value):
     try:
         return _MAP[str(value).lower()]
-    except KeyError:
-        raise ValueError('"{}" is not a valid bool value'.format(value))
+    except KeyError as error:
+        raise ValueError('"{}" is not a valid bool value'.format(value)) from error