Only save config if send is successful

This commit is contained in:
medmunds committed 2021-02-14 13:10:30 -08:00
1 parent e48b6bd22d
commit 2439bb30e8
1 file changed
+7 -6
+7 -6
View File
@@ -78,6 +78,13 @@ smtp_send() {
SMTP_TIMEOUT="${SMTP_TIMEOUT:-$(_readaccountconf_mutable SMTP_TIMEOUT)}"
SMTP_DEFAULT_TIMEOUT="15"
# Send the message:
if ! _smtp_send "$@"; then
_err "$smtp_send_output"
return 1
fi
# Save remaining config if successful. (SMTP_PYTHON is saved earlier.)
_saveaccountconf_mutable SMTP_FROM "$SMTP_FROM"
_saveaccountconf_mutable SMTP_TO "$SMTP_TO"
_saveaccountconf_mutable SMTP_HOST "$SMTP_HOST"
@@ -87,12 +94,6 @@ smtp_send() {
_saveaccountconf_mutable SMTP_PASSWORD "$SMTP_PASSWORD"
_saveaccountconf_mutable SMTP_TIMEOUT "$SMTP_TIMEOUT"
# Send the message:
if ! _smtp_send "$@"; then
_err "$smtp_send_output"
return 1
fi
return 0
}
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.