Commit Graph
3 Commits
Author SHA1 Message Date
Bastian Bittorf 3ca93f4a4c shellcheck: fix several occurences of SC2034
message:
SC2034: $VARNAME appears unused. Verify it or export it.

most of these are related to the style:
we generate global vars, which are used in other functions.

the var "lexical_url" was really unused (left it as comment)

the travis-check now does not need anymore special flags.

Signed-off-by: Bastian Bittorf <bb@npl.de>
2017-01-13 14:54:09 +01:00
Bastian Bittorf 3b67cf4378 dnsapi/dns_dp.sh: shellcheck: fix 1 occurence of SC2126
shellcheck message was:
"Consider using grep -c instead of grep | wc"
2017-01-09 15:08:41 +01:00
Bastian Bittorf 800f02ba38 dnsapi/dns_lexicon.sh: shellcheck: fix 4 occurences of SC2021:
"Don't use [] around ranges in tr, it replaces literal square brackets."

this introduces another warning:
"Use '[:lower:]' to support accents and foreign alphabets."

This is more a style thingy because we really want to only catch A-Z.
work around this by using a shellcheck-directive and a comment
that the [:lower:] will not work with e.g. busybox-ash.

if we later really want to use [:lower:], we should use 'sed' for that.
2017-01-09 12:21:32 +01:00